]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net/mlx5e: Disable preemption when doing TC statistics upcall
authorOr Gerlitz <ogerlitz@mellanox.com>
Sun, 12 Feb 2017 09:21:31 +0000 (11:21 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Feb 2017 16:56:01 +0000 (11:56 -0500)
commitfed06ee89b78d3af32e235e0e89ad0d946fcb95d
treeea5cdbd80e1b11382fc2b557aa262dcccfbb35ba
parent0c8ef291d976221319f70753c62e18b48d892590
net/mlx5e: Disable preemption when doing TC statistics upcall

When called by HW offloading drivers, the TC action (e.g
net/sched/act_mirred.c) code uses this_cpu logic, e.g

 _bstats_cpu_update(this_cpu_ptr(a->cpu_bstats), bytes, packets)

per the kernel documention, preemption should be disabled, add that.

Before the fix, when running with CONFIG_PREEMPT set, we get a

BUG: using smp_processor_id() in preemptible [00000000] code: tc/3793

asserion from the TC action (mirred) stats_update callback.

Fixes: aad7e08d39bd ('net/mlx5e: Hardware offloaded flower filter statistics support')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c