]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
floppy: fix open(O_ACCMODE) for ioctl-only open
authorJiri Kosina <jkosina@suse.cz>
Thu, 16 Jun 2016 07:53:58 +0000 (09:53 +0200)
committerJens Axboe <axboe@fb.com>
Thu, 4 Aug 2016 20:19:16 +0000 (14:19 -0600)
commitff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e
tree9de4ce114a0583d3ceab6cd1795bb520092dc836
parentc1ece76719205690f4b448460d9b85c130e8021b
floppy: fix open(O_ACCMODE) for ioctl-only open

Commit 09954bad4 ("floppy: refactor open() flags handling"), as a
side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that
this is being used setfdprm userspace for ioctl-only open().

Reintroduce back the original behavior wrt !(FMODE_READ|FMODE_WRITE)
modes, while still keeping the original O_NDELAY bug fixed.

Cc: stable@vger.kernel.org # v4.5+
Reported-by: Wim Osterholt <wim@djo.tudelft.nl>
Tested-by: Wim Osterholt <wim@djo.tudelft.nl>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/floppy.c