]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: dsa: mt7530: set all CPU ports in MT7531_CPU_PMAP
authorArınç ÜNAL <arinc.unal@arinc9.com>
Sat, 17 Jun 2023 06:26:44 +0000 (09:26 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Jun 2023 08:40:25 +0000 (09:40 +0100)
commitff221029a51fd54cacac66e193e0c75e4de940e7
tree923ec8c91221cc00c04e9962a3214f44a88b4310
parent9a43827e876c9a071826cc81783aa2222b020f1d
net: dsa: mt7530: set all CPU ports in MT7531_CPU_PMAP

MT7531_CPU_PMAP represents the destination port mask for trapped-to-CPU
frames (further restricted by PCR_MATRIX).

Currently the driver sets the first CPU port as the single port in this bit
mask, which works fine regardless of whether the device tree defines port
5, 6 or 5+6 as CPU ports. This is because the logic coincides with DSA's
logic of picking the first CPU port as the CPU port that all user ports are
affine to, by default.

An upcoming change would like to influence DSA's selection of the default
CPU port to no longer be the first one, and in that case, this logic needs
adaptation.

Since there is no observed leakage or duplication of frames if all CPU
ports are defined in this bit mask, simply include them all.

Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
Suggested-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mt7530.c
drivers/net/dsa/mt7530.h