Slightly more readable, plus we also strip leading spaces.
Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
size_t count, loff_t *ppos)
{
struct request_queue *q = file_inode(file)->i_private;
size_t count, loff_t *ppos)
{
struct request_queue *q = file_inode(file)->i_private;
+ char opbuf[16] = { }, *op;
- if (count >= sizeof(op)) {
+ if (count >= sizeof(opbuf)) {
pr_err("%s: operation too long\n", __func__);
goto inval;
}
pr_err("%s: operation too long\n", __func__);
goto inval;
}
- if (copy_from_user(op, buf, count))
+ if (copy_from_user(opbuf, buf, count))
- s = op;
- strsep(&s, " \t\n"); /* strip trailing whitespace */
if (strcmp(op, "run") == 0) {
blk_mq_run_hw_queues(q, true);
} else if (strcmp(op, "start") == 0) {
if (strcmp(op, "run") == 0) {
blk_mq_run_hw_queues(q, true);
} else if (strcmp(op, "start") == 0) {