fixups for DatastoreFSyncLevel:
* use derive for Default
* add some more derives (Clone, Copy)
chunk store:
* drop to_owned for chunk_dir_path
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
-#[derive(PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, Copy, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "lowercase")]
/// The level of syncing that is done when writing into a datastore.
pub enum DatastoreFSyncLevel {
#[serde(rename_all = "lowercase")]
/// The level of syncing that is done when writing into a datastore.
pub enum DatastoreFSyncLevel {
/// which reduces IO pressure.
/// But it may cause losing data on powerloss or system crash without any uninterruptible power
/// supply.
/// which reduces IO pressure.
/// But it may cause losing data on powerloss or system crash without any uninterruptible power
/// supply.
None,
/// Triggers a fsync after writing any chunk on the datastore. While this can slow down
/// backups significantly, depending on the underlying file system and storage used, it
None,
/// Triggers a fsync after writing any chunk on the datastore. While this can slow down
/// backups significantly, depending on the underlying file system and storage used, it
-impl Default for DatastoreFSyncLevel {
- fn default() -> Self {
- DatastoreFSyncLevel::None
- }
-}
-
#[api(
properties: {
"chunk-order": {
#[api(
properties: {
"chunk-order": {
let chunk_dir_path = chunk_path
.parent()
let chunk_dir_path = chunk_path
.parent()
- .ok_or_else(|| format_err!("unable to get chunk dir"))?
- .to_owned();
+ .ok_or_else(|| format_err!("unable to get chunk dir"))?;
proxmox_sys::fs::replace_file(
proxmox_sys::fs::replace_file(
raw_data,
CreateOptions::new(),
self.sync_level == DatastoreFSyncLevel::File,
raw_data,
CreateOptions::new(),
self.sync_level == DatastoreFSyncLevel::File,