The creation of a new `struct bgp_path_info` requires a legitimate
peer being passed in for creation. There exists no code paths
where this is not true. As such checking pi->peer for null convinces
SA that it might happen.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
continue;
if (BGP_PATH_HOLDDOWN(pi1))
continue;
continue;
if (BGP_PATH_HOLDDOWN(pi1))
continue;
- if (pi1->peer && pi1->peer != bgp->peer_self)
+ if (pi1->peer != bgp->peer_self)
if (pi1->peer->status != Established)
continue;
if (pi1->peer->status != Established)
continue;
continue;
if (BGP_PATH_HOLDDOWN(pi2))
continue;
continue;
if (BGP_PATH_HOLDDOWN(pi2))
continue;
- if (pi2->peer
- && pi2->peer != bgp->peer_self
+ if (pi2->peer != bgp->peer_self
- pi2->peer->sflags,
- PEER_STATUS_NSF_WAIT))
+ pi2->peer->sflags,
+ PEER_STATUS_NSF_WAIT))
if (pi2->peer->status
!= Established)
continue;
if (pi2->peer->status
!= Established)
continue;