]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
Input: spaceball - mark expected switch fall-throughs
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 10 Nov 2017 18:23:14 +0000 (10:23 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 10 Nov 2017 18:29:54 +0000 (10:29 -0800)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114767
Addresses-Coverity-ID: 114768
Addresses-Coverity-ID: 114769
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/spaceball.c

index e9712a1b7cad93a35ed244a647ddeb494f0e494f..bb3faeff8cac8874a65d39f3a93d6390a759b203 100644 (file)
@@ -162,6 +162,7 @@ static irqreturn_t spaceball_interrupt(struct serio *serio,
                                break;
                        }
                        spaceball->escape = 0;
+                       /* fall through */
                case 'M':
                case 'Q':
                case 'S':
@@ -169,6 +170,7 @@ static irqreturn_t spaceball_interrupt(struct serio *serio,
                                spaceball->escape = 0;
                                data &= 0x1f;
                        }
+                       /* fall through */
                default:
                        if (spaceball->escape)
                                spaceball->escape = 0;
@@ -234,11 +236,13 @@ static int spaceball_connect(struct serio *serio, struct serio_driver *drv)
                        input_dev->keybit[BIT_WORD(BTN_A)] |= BIT_MASK(BTN_A) |
                                BIT_MASK(BTN_B) | BIT_MASK(BTN_C) |
                                BIT_MASK(BTN_MODE);
+                       /* fall through */
                default:
                        input_dev->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_2) |
                                BIT_MASK(BTN_3) | BIT_MASK(BTN_4) |
                                BIT_MASK(BTN_5) | BIT_MASK(BTN_6) |
                                BIT_MASK(BTN_7) | BIT_MASK(BTN_8);
+                       /* fall through */
                case SPACEBALL_3003C:
                        input_dev->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_1) |
                                BIT_MASK(BTN_8);