]> git.proxmox.com Git - mirror_frr.git/commitdiff
tests: Allow a bit longer for bfd topo tests to synchronize
authorDonald Sharp <sharpd@nvidia.com>
Thu, 19 May 2022 23:28:43 +0000 (19:28 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Fri, 20 May 2022 14:31:48 +0000 (10:31 -0400)
Allowing only 4 seconds for a bfd test to synchronize is going
to run into problems on extremely loaded systems.  The test
system should value it actually converged over it actually
converged in a reasonable time, especially on test systems
that are loaded because of many multiples of tests running
at the same time.  If it is important to actually test
that something got done by the RFC, the CI system as it
is currently written is not the correct place for this.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
tests/topotests/bfd_topo1/test_bfd_topo1.py
tests/topotests/bfd_topo2/test_bfd_topo2.py

index adf02b02d42946cacf5d7d597ca6d3d28d8ba11c..c9020f16d38bedaf83dfa7506dcc189b4c63d8cf 100644 (file)
@@ -100,7 +100,7 @@ def test_bfd_connection():
         test_func = partial(
             topotest.router_json_cmp, router, "show bfd peers json", expected
         )
-        _, result = topotest.run_and_expect(test_func, None, count=8, wait=0.5)
+        _, result = topotest.run_and_expect(test_func, None, count=30, wait=0.5)
         assertmsg = '"{}" JSON output mismatches'.format(router.name)
         assert result is None, assertmsg
 
index 57ce0cdf09b9a18ffeb85bbeaf037dd1febef422..a9b9358ef07708e275cdee08eae972c76c57cf31 100644 (file)
@@ -144,7 +144,7 @@ def test_bfd_connection():
         test_func = partial(
             topotest.router_json_cmp, router, "show bfd peers json", expected
         )
-        _, result = topotest.run_and_expect(test_func, None, count=8, wait=0.5)
+        _, result = topotest.run_and_expect(test_func, None, count=30, wait=0.5)
         assertmsg = '"{}" JSON output mismatches'.format(router.name)
         assert result is None, assertmsg