]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
irqchip: brcmstb-l2: Level-2 interrupts are edge sensitive
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 9 Jun 2014 18:05:02 +0000 (11:05 -0700)
committerJason Cooper <jason@lakedaemon.net>
Sat, 21 Jun 2014 02:08:34 +0000 (02:08 +0000)
The driver was configuring the interrupt handler for the Level-2
interrupts to be "level" triggered while they are in fact "edge"
triggered. Fix this by using the correct handler.

Reported-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lkml.kernel.org/r/1402337102-19428-1-git-send-email-f.fainelli@gmail.com
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
drivers/irqchip/irq-brcmstb-l2.c

index 8ee2a36d58405b03b9d9655338d4bc7664a72939..c15c840987d2808e82cf1b056c231005933c5f8b 100644 (file)
@@ -150,7 +150,7 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np,
 
        /* Allocate a single Generic IRQ chip for this node */
        ret = irq_alloc_domain_generic_chips(data->domain, 32, 1,
-                               np->full_name, handle_level_irq, clr, 0, 0);
+                               np->full_name, handle_edge_irq, clr, 0, 0);
        if (ret) {
                pr_err("failed to allocate generic irq chip\n");
                goto out_free_domain;