]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
rtc: isl12057: use PTR_ERR_OR_ZERO to fix coccinelle warnings
authorFengguang Wu <fengguang.wu@intel.com>
Tue, 18 Feb 2014 18:00:21 +0000 (18:00 +0000)
committerJason Cooper <jason@lakedaemon.net>
Tue, 18 Feb 2014 18:00:21 +0000 (18:00 +0000)
drivers/rtc/rtc-isl12057.c:278:1-3: WARNING: PTR_RET can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: coccinelle/api/ptr_ret.cocci

CC: Arnaud Ebalard <arno@natisbad.org>
CC: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
drivers/rtc/rtc-isl12057.c

index 7854a656628fc311a1abd3b87453d3e12cff38c4..835b425549bd4138886da6c5754ecde38482b857 100644 (file)
@@ -275,10 +275,7 @@ static int isl12057_probe(struct i2c_client *client,
        dev_set_drvdata(dev, data);
 
        rtc = devm_rtc_device_register(dev, DRV_NAME, &rtc_ops, THIS_MODULE);
-       if (IS_ERR(rtc))
-               return PTR_ERR(rtc);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(rtc);
 }
 
 #ifdef CONFIG_OF