ath11k: fix wmi peer flags in peer assoc command

Currently need ptk/gtk wmi peer flags in wmi peer assoc cmd
are set based on the rsnie and wpaie of the bss from the bss list.
Since this bss list is not updated with current BSSID for AP mode,
we may not find bss from the bss list. Which results in ptk/gtk peer
flags are not set in the wmi peer assoc cmd. Due to this EAPOL frames
are going in data rates instead of management rates.

Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01228-QCAHKSWPL_SILICONZ-1

Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1591771841-25503-1-git-send-email-vnaralas@codeaurora.org

diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h
index 46e53da498844a29e8ecaa3521f5f7497fa35c9d..e5c4e19020ee2dfe9cd5d0a74c37e714479dd03b 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/core.h
+++ b/drivers/net/wireless/ath/ath11k/core.h
@@ -224,6 +224,8 @@ struct ath11k_vif {
        int num_legacy_stations;
        int rtscts_prot_mode;
        int txpower;
+       bool rsnie_present;
+       bool wpaie_present;
 };
 
 struct ath11k_vif_iter {

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 5ba8f098607952488b6cb08ed2ff913d669a7a69..07d3e031c75a463bdc3fa8bdbc5428968c60199f 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -780,6 +780,8 @@ static int ath11k_mac_setup_bcn_tmpl(struct ath11k_vif *arvif)
        struct ieee80211_vif *vif = arvif->vif;
        struct ieee80211_mutable_offsets offs = {};
        struct sk_buff *bcn;
+       struct ieee80211_mgmt *mgmt;
+       u8 *ies;
        int ret;
 
        if (arvif->vdev_type != WMI_VDEV_TYPE_AP)
@@ -791,6 +793,17 @@ static int ath11k_mac_setup_bcn_tmpl(struct ath11k_vif *arvif)
                return -EPERM;
        }
 
+       ies = bcn->data + ieee80211_get_hdrlen_from_skb(bcn);
+       ies += sizeof(mgmt->u.beacon);
+
+       if (cfg80211_find_ie(WLAN_EID_RSN, ies, (skb_tail_pointer(bcn) - ies)))
+               arvif->rsnie_present = true;
+
+       if (cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
+                                   WLAN_OUI_TYPE_MICROSOFT_WPA,
+                                   ies, (skb_tail_pointer(bcn) - ies)))
+               arvif->wpaie_present = true;
+
        ret = ath11k_wmi_bcn_tmpl(ar, arvif->vdev_id, &offs, bcn);
 
        kfree_skb(bcn);
@@ -880,6 +893,7 @@ static void ath11k_peer_assoc_h_crypto(struct ath11k *ar,
        struct ieee80211_bss_conf *info = &vif->bss_conf;
        struct cfg80211_chan_def def;
        struct cfg80211_bss *bss;
+       struct ath11k_vif *arvif = (struct ath11k_vif *)vif->drv_priv;
        const u8 *rsnie = NULL;
        const u8 *wpaie = NULL;
 
@@ -890,7 +904,12 @@ static void ath11k_peer_assoc_h_crypto(struct ath11k *ar,
 
        bss = cfg80211_get_bss(ar->hw->wiphy, def.chan, info->bssid, NULL, 0,
                               IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY);
-       if (bss) {
+
+       if (arvif->rsnie_present || arvif->wpaie_present) {
+               arg->need_ptk_4_way = true;
+               if (arvif->wpaie_present)
+                       arg->need_gtk_2_way = true;
+       } else if (bss) {
                const struct cfg80211_bss_ies *ies;
 
                rcu_read_lock();

diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 457a9f79f351887802fad6a14b4985082d5b2344..8e3437a65673692a7bc7a13aa8d4efc67bae2f53 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -1728,10 +1728,10 @@ ath11k_wmi_copy_peer_flags(struct wmi_peer_assoc_complete_cmd *cmd,
         */
        if (param->auth_flag)
                cmd->peer_flags |= WMI_PEER_AUTH;
-       if (param->need_ptk_4_way)
+       if (param->need_ptk_4_way) {
                cmd->peer_flags |= WMI_PEER_NEED_PTK_4_WAY;
-       else
-               cmd->peer_flags &= ~WMI_PEER_NEED_PTK_4_WAY;
+               cmd->peer_flags &= ~WMI_PEER_AUTH;
+       }
        if (param->need_gtk_2_way)
                cmd->peer_flags |= WMI_PEER_NEED_GTK_2_WAY;
        /* safe mode bypass the 4-way handshake */