]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ipv4: move from strlcpy with unused retval to strscpy
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 18 Aug 2022 21:02:19 +0000 (23:02 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 23 Aug 2022 00:59:37 +0000 (17:59 -0700)
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20220818210219.8467-1-wsa+renesas@sang-engineering.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/arp.c

index 87c7e3fc5197342ce49f10f15f14bdf0036331ea..4f7237661afb9b2c1a11a1740eae823443ebdea4 100644 (file)
@@ -1129,7 +1129,7 @@ static int arp_req_get(struct arpreq *r, struct net_device *dev)
                        r->arp_flags = arp_state_to_flags(neigh);
                        read_unlock_bh(&neigh->lock);
                        r->arp_ha.sa_family = dev->type;
-                       strlcpy(r->arp_dev, dev->name, sizeof(r->arp_dev));
+                       strscpy(r->arp_dev, dev->name, sizeof(r->arp_dev));
                        err = 0;
                }
                neigh_release(neigh);