ASoC: Intel: atom: Take the drv->lock mutex before calling sst_send_slot_map()

BugLink: https://bugs.launchpad.net/bugs/1876361
[ Upstream commit 81630dc042af998b9f58cd8e2c29dab9777ea176 ]

sst_send_slot_map() uses sst_fill_and_send_cmd_unlocked() because in some
places it is called with the drv->lock mutex already held.

So it must always be called with the mutex locked. This commit adds missing
locking in the sst_set_be_modules() code-path.

Fixes: 24c8d14192cc ("ASoC: Intel: mrfld: add DSP core controls")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200402185359.3424-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c
index f883c9340eeee6d6412cce15227bc86020f9802d..df8f7994d3b7a7eb7d04b404e57243acf875708c 100644 (file)
--- a/sound/soc/intel/atom/sst-atom-controls.c
+++ b/sound/soc/intel/atom/sst-atom-controls.c
@@ -966,7 +966,9 @@ static int sst_set_be_modules(struct snd_soc_dapm_widget *w,
        dev_dbg(c->dev, "Enter: widget=%s\n", w->name);
 
        if (SND_SOC_DAPM_EVENT_ON(event)) {
+               mutex_lock(&drv->lock);
                ret = sst_send_slot_map(drv);
+               mutex_unlock(&drv->lock);
                if (ret)
                        return ret;
                ret = sst_send_pipe_module_params(w, k);