]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/rockchip: cdn-dp-core: Make cdn_dp_core_resume __maybe_unused
authorArnd Bergmann <arnd@arndb.de>
Tue, 28 Apr 2020 21:31:24 +0000 (23:31 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 16 Sep 2021 19:02:33 +0000 (12:02 -0700)
With the new static annotation, the compiler warns when the functions
are actually unused:

   drivers/gpu/drm/rockchip/cdn-dp-core.c:1123:12: error: 'cdn_dp_resume' defined but not used [-Werror=unused-function]
    1123 | static int cdn_dp_resume(struct device *dev)
         |            ^~~~~~~~~~~~~

Mark them __maybe_unused to suppress that warning as well.

[ Not so 'new' static annotations any more, and I removed the part of
  the patch that added __maybe_unused to cdn_dp_suspend(), because it's
  used by the shutdown/remove code.

  So only the resume function ends up possibly unused if CONFIG_PM isn't
  set     - Linus ]

Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/gpu/drm/rockchip/cdn-dp-core.c

index 8ab3247dbc4aab72f20c44f5227612ad20413b09..13c6b857158fcf63b2106ad62d496e4997af7534 100644 (file)
@@ -1123,7 +1123,7 @@ static int cdn_dp_suspend(struct device *dev)
        return ret;
 }
 
-static int cdn_dp_resume(struct device *dev)
+static __maybe_unused int cdn_dp_resume(struct device *dev)
 {
        struct cdn_dp_device *dp = dev_get_drvdata(dev);