]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop
authorWesley Cheng <quic_wcheng@quicinc.com>
Thu, 28 Jul 2022 02:06:47 +0000 (19:06 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Aug 2022 19:10:44 +0000 (21:10 +0200)
Relocate the pullups_connected check until after it is ensured that there
are no runtime PM transitions.  If another context triggered the DWC3
core's runtime resume, it may have already enabled the Run/Stop.  Do not
re-run the entire pullup sequence again, as it may issue a core soft
reset while Run/Stop is already set.

This patch depends on
  commit 69e131d1ac4e ("usb: dwc3: gadget: Prevent repeat pullup()")

Fixes: 77adb8bdf422 ("usb: dwc3: gadget: Allow runtime suspend if UDC unbinded")
Cc: stable <stable@kernel.org>
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Link: https://lore.kernel.org/r/20220728020647.9377-1-quic_wcheng@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/gadget.c

index aeeec751c53c7b9b8423e2962d6fe463b94dc0c7..eca945feeec3e7615935605387b0805cd333933a 100644 (file)
@@ -2539,9 +2539,6 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on)
 
        is_on = !!is_on;
 
-       if (dwc->pullups_connected == is_on)
-               return 0;
-
        dwc->softconnect = is_on;
 
        /*
@@ -2566,6 +2563,11 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on)
                return 0;
        }
 
+       if (dwc->pullups_connected == is_on) {
+               pm_runtime_put(dwc->dev);
+               return 0;
+       }
+
        if (!is_on) {
                ret = dwc3_gadget_soft_disconnect(dwc);
        } else {