]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
can: usb: esd_usb2: esd_usb2_rx_event(): fix the interchange of the CAN RX and TX...
authorStefan Mätje <stefan.maetje@esd.eu>
Wed, 25 Aug 2021 21:52:27 +0000 (23:52 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 26 Aug 2021 06:37:13 +0000 (08:37 +0200)
This patch fixes the interchanged fetch of the CAN RX and TX error
counters from the ESD_EV_CAN_ERROR_EXT message. The RX error counter
is really in struct rx_msg::data[2] and the TX error counter is in
struct rx_msg::data[3].

Fixes: 96d8e90382dc ("can: Add driver for esd CAN-USB/2 device")
Link: https://lore.kernel.org/r/20210825215227.4947-2-stefan.maetje@esd.eu
Cc: stable@vger.kernel.org
Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/esd_usb2.c

index 66fa8b07c2e6f66e7c4555c780d081a4cd844016..95ae740fc31100fa59f1f8f4c9df125130307e9e 100644 (file)
@@ -224,8 +224,8 @@ static void esd_usb2_rx_event(struct esd_usb2_net_priv *priv,
        if (id == ESD_EV_CAN_ERROR_EXT) {
                u8 state = msg->msg.rx.data[0];
                u8 ecc = msg->msg.rx.data[1];
-               u8 txerr = msg->msg.rx.data[2];
-               u8 rxerr = msg->msg.rx.data[3];
+               u8 rxerr = msg->msg.rx.data[2];
+               u8 txerr = msg->msg.rx.data[3];
 
                skb = alloc_can_err_skb(priv->netdev, &cf);
                if (skb == NULL) {