]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
net: tipc: name_table: Replace GFP_ATOMIC with GFP_KERNEL in tipc_nametbl_init()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 09:28:25 +0000 (17:28 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Jul 2018 20:45:15 +0000 (13:45 -0700)
tipc_nametbl_init() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/name_table.c

index bebe88cae07bef565d191aea1bb08acd1f3c1cbd..88f027b502f6f5ed955b03bd645321ea8e79eec3 100644 (file)
@@ -735,7 +735,7 @@ int tipc_nametbl_init(struct net *net)
        struct name_table *nt;
        int i;
 
-       nt = kzalloc(sizeof(*nt), GFP_ATOMIC);
+       nt = kzalloc(sizeof(*nt), GFP_KERNEL);
        if (!nt)
                return -ENOMEM;