]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
USB: ehci-tegra: remove redundant gpio_set_value
authorStephen Warren <swarren@nvidia.com>
Mon, 30 Apr 2012 23:24:10 +0000 (17:24 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 May 2012 18:11:51 +0000 (14:11 -0400)
The immediately preceding gpio_direction_output() already set the value,
so there's no need to repeat it. This also prevents gpio_set_value() from
WARNing when the GPIO is sleepable (e.g. is on an I2C expander); the set
direction API is always sleepable, but plain set_value isn't.

Cc: <stable@vger.kernel.org> # v3.3
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-tegra.c

index 73f3525e6921be8e93627c30bb2ed3e3d4bf3b83..f214a80cdee212ec816601ef51645b05fd3f6d68 100644 (file)
@@ -458,7 +458,6 @@ static int setup_vbus_gpio(struct platform_device *pdev)
                dev_err(&pdev->dev, "can't enable vbus\n");
                return err;
        }
-       gpio_set_value(gpio, 1);
 
        return err;
 }