]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
ubi: wl: Fix uninitialized variable
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Sat, 2 Mar 2019 19:59:07 +0000 (13:59 -0600)
committerRichard Weinberger <richard@nod.at>
Tue, 7 May 2019 19:58:33 +0000 (21:58 +0200)
There is a potential execution path in which variable *err*
is compared against UBI_IO_BITFLIPS without being properly
initialized previously.

Fix this by initializing variable *err* to 0.

Addresses-Coverity-ID: 1477298 "(Uninitialized scalar variable")
Fixes: 663586c0a892 ("ubi: Expose the bitrot interface")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
drivers/mtd/ubi/wl.c

index 2709dc02fc249922578d9a8c4eb63369c90469d4..1f56c655832bec1fc3ab9f6a38a9a958ff58a355 100644 (file)
@@ -1475,7 +1475,7 @@ static bool scrub_possible(struct ubi_device *ubi, struct ubi_wl_entry *e)
  */
 int ubi_bitflip_check(struct ubi_device *ubi, int pnum, int force)
 {
-       int err;
+       int err = 0;
        struct ubi_wl_entry *e;
 
        if (pnum < 0 || pnum >= ubi->peb_count) {