]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
gve: Set default duplex configuration to full
authorJunfeng Guo <junfeng.guo@intel.com>
Thu, 6 Jul 2023 04:41:28 +0000 (12:41 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 7 Jul 2023 02:14:24 +0000 (19:14 -0700)
Current duplex mode was unset in the driver, resulting in the default
parameter being set to 0, which corresponds to half duplex. It might
mislead users to have incorrect expectation about the driver's
transmission capabilities.
Set the default duplex configuration to full, as the driver runs in
full duplex mode at this point.

Fixes: 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.")
Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Message-ID: <20230706044128.2726747-1-junfeng.guo@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/google/gve/gve_ethtool.c

index cfd4b8d284d12eaaf1b7fef612c3db47fbf0bc8d..50162ec9424dfc057662af5b232239f65185a064 100644 (file)
@@ -590,6 +590,9 @@ static int gve_get_link_ksettings(struct net_device *netdev,
                err = gve_adminq_report_link_speed(priv);
 
        cmd->base.speed = priv->link_speed;
+
+       cmd->base.duplex = DUPLEX_FULL;
+
        return err;
 }