pinctrl: renesas: checker: Fix off-by-one bug in drive register check

BugLink: https://bugs.launchpad.net/bugs/1951822
[ Upstream commit 28e7f8ff90583791a034d43b5d2e3fe394142e13 ]

The GENMASK(h, l) macro creates a contiguous bitmask starting at bit
position @l and ending at position @h, inclusive.

This did not trigger any error checks, as the individual register fields
cover at most 3 of the 4 available bits.

Fixes: 08df16e07ad0a1ec ("pinctrl: sh-pfc: checker: Add drive strength register checks")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/8f82d6147fbe3367d4c83962480e97f58d9c96a2.1633615652.git.geert+renesas@glider.be
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

diff --git a/drivers/pinctrl/renesas/core.c b/drivers/pinctrl/renesas/core.c
index f2ab02225837ec3b929d426218e2e53158305347..f29130957e49a23d2245c6f07bb906d452b2353f 100644 (file)
--- a/drivers/pinctrl/renesas/core.c
+++ b/drivers/pinctrl/renesas/core.c
@@ -890,7 +890,7 @@ static void __init sh_pfc_check_drive_reg(const struct sh_pfc_soc_info *info,
                if (!field->pin && !field->offset && !field->size)
                        continue;
 
-               mask = GENMASK(field->offset + field->size, field->offset);
+               mask = GENMASK(field->offset + field->size - 1, field->offset);
                if (mask & seen)
                        sh_pfc_err("drive_reg 0x%x: field %u overlap\n",
                                   drive->reg, i);