pinctrl: nomadik: Fix refcount leak in nmk_pinctrl_dt_subnode_to_map

BugLink: https://bugs.launchpad.net/bugs/1990564
commit 4b32e054335ea0ce50967f63a7bfd4db058b14b9 upstream.

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak."

Fixes: c2f6d059abfc ("pinctrl: nomadik: refactor DT parser to take two paths")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220607111602.57355-1-linmq006@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index 4757bf964d3cd304c3576ce669640a31e661e6da..6dd930a839ecc6c9254fda6c245baac4324231ce 100644 (file)
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -1421,8 +1421,10 @@ static int nmk_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
 
        has_config = nmk_pinctrl_dt_get_config(np, &configs);
        np_config = of_parse_phandle(np, "ste,config", 0);
-       if (np_config)
+       if (np_config) {
                has_config |= nmk_pinctrl_dt_get_config(np_config, &configs);
+               of_node_put(np_config);
+       }
        if (has_config) {
                const char *gpio_name;
                const char *pin;