]> git.proxmox.com Git - mirror_qemu.git/commitdiff
linux-user/ppc: Narrow type of ccr in save_user_regs
authorRichard Henderson <richard.henderson@linaro.org>
Mon, 4 Apr 2022 06:49:06 +0000 (08:49 +0200)
committerCédric Le Goater <clg@kaod.org>
Mon, 4 Apr 2022 06:49:06 +0000 (08:49 +0200)
Coverity warns that we shift a 32-bit value by N, and then
accumulate it into a 64-bit type (target_ulong on ppc64).

The ccr is always 8 * 4-bit fields, and thus is always a
32-bit quantity; narrow the type to avoid the warning.

Fixes: Coverity CID 1487223
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20220401191643.330393-1-richard.henderson@linaro.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
linux-user/ppc/signal.c

index ec0b9c0df3da461c1ff6fb26f1389d2e5ebb7840..ce5a4682cdfd3f8ce2f207a6bdc851928b111bb5 100644 (file)
@@ -229,7 +229,7 @@ static void save_user_regs(CPUPPCState *env, struct target_mcontext *frame)
 {
     target_ulong msr = env->msr;
     int i;
-    target_ulong ccr = 0;
+    uint32_t ccr = 0;
 
     /* In general, the kernel attempts to be intelligent about what it
        needs to save for Altivec/FP/SPE registers.  We don't care that