]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
dsa:mv88e6xxx: allow address 0x1 in smi_init
authorVolodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
Tue, 3 Jan 2017 09:49:09 +0000 (10:49 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 Jan 2017 15:01:58 +0000 (10:01 -0500)
Some devices, such as the mv88e6097 do have ADDR[0] external and so it
is possible to configure the device to use SMI address 0x1. Remove the
restriction, as there are boards using this address.

Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/chip.c

index f7222dc6581de1e75d439550520f8108b1d2744e..b5f0e1ec864d838f7c5dacb0d08e82861927efb5 100644 (file)
@@ -4240,10 +4240,6 @@ static void mv88e6xxx_phy_destroy(struct mv88e6xxx_chip *chip)
 static int mv88e6xxx_smi_init(struct mv88e6xxx_chip *chip,
                              struct mii_bus *bus, int sw_addr)
 {
-       /* ADDR[0] pin is unavailable externally and considered zero */
-       if (sw_addr & 0x1)
-               return -EINVAL;
-
        if (sw_addr == 0)
                chip->smi_ops = &mv88e6xxx_smi_single_chip_ops;
        else if (mv88e6xxx_has(chip, MV88E6XXX_FLAGS_MULTI_CHIP))