]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
spi: bcm2835aux: change initialization order and switch to platform_get_irq
authorMartin Sperl <kernel@martin.sperl.org>
Thu, 15 Oct 2015 10:10:20 +0000 (10:10 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 16 Oct 2015 14:35:33 +0000 (15:35 +0100)
Change the initialization order of the HW so that the interrupt
is only requested after the HW is initialized

Also the use of irq_of_parse_and_map is replaced by platform_get_irq.

Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-bcm2835aux.c

index 05d2d6eb7bfa42fb4d9e5fc3bbe306783f2280db..7de6f8472a8100656884647ad5447be94604e7bb 100644 (file)
@@ -429,7 +429,7 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev)
                goto out_master_put;
        }
 
-       bs->irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
+       bs->irq = platform_get_irq(pdev, 0);
        if (bs->irq <= 0) {
                dev_err(&pdev->dev, "could not get IRQ: %d\n", bs->irq);
                err = bs->irq ? bs->irq : -ENODEV;
@@ -451,6 +451,9 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev)
                goto out_clk_disable;
        }
 
+       /* reset SPI-HW block */
+       bcm2835aux_spi_reset_hw(bs);
+
        err = devm_request_irq(&pdev->dev, bs->irq,
                               bcm2835aux_spi_interrupt,
                               IRQF_SHARED,
@@ -460,9 +463,6 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev)
                goto out_clk_disable;
        }
 
-       /* reset SPI-HW block */
-       bcm2835aux_spi_reset_hw(bs);
-
        err = devm_spi_register_master(&pdev->dev, master);
        if (err) {
                dev_err(&pdev->dev, "could not register SPI master: %d\n", err);