2009-11-25 Robert Millan <rmh.grub@aybabtu.com>

        * normal/main.c (grub_normal_read_line): Fix off-by-one
        buffer overflow..

diff --git a/ChangeLog b/ChangeLog
index 27d538c0448d3e04cd7842d06a5788cc0733a098..dd26cb18c38e6a1a58b5e0cfe8ce0ad491c8a889 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-11-25  Robert Millan  <rmh.grub@aybabtu.com>
+
+       * normal/main.c (grub_normal_read_line): Fix off-by-one
+       buffer overflow.
+
 2009-11-25  Robert Millan  <rmh.grub@aybabtu.com>
 
        * normal/main.c (grub_normal_execute): Replace "parser.sh" with

diff --git a/normal/main.c b/normal/main.c
index a753ab0c435b076f11c04b95761618fea2024180..dcc91c6492a9fea253834f98c6905451d401f795 100644 (file)
--- a/normal/main.c
+++ b/normal/main.c
@@ -524,7 +524,7 @@ static grub_err_t
 grub_normal_read_line (char **line, int cont)
 {
   grub_parser_t parser = grub_parser_get_current ();
-  char prompt[sizeof("> ") - 1 + grub_strlen (parser->name)];
+  char prompt[sizeof("> ") + grub_strlen (parser->name)];
 
   grub_sprintf (prompt, "%s> ", parser->name);