usb: cdns3: Added CDNS3_ID_PERIPHERAL and CDNS3_ID_HOST

Patch adds 2 definitions that make it easier to understand the code.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>

diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
index 6fe092c828b3a2dc0fe0f79a36724e64f7d83c12..8e7673da905ed62cff22acd71f2e58f25163036b 100644 (file)
--- a/drivers/usb/cdns3/drd.c
+++ b/drivers/usb/cdns3/drd.c
@@ -87,7 +87,7 @@ bool cdns3_is_host(struct cdns3 *cdns)
 {
        if (cdns->dr_mode == USB_DR_MODE_HOST)
                return true;
-       else if (!cdns3_get_id(cdns))
+       else if (cdns3_get_id(cdns) == CDNS3_ID_HOST)
                return true;
 
        return false;
@@ -98,7 +98,7 @@ bool cdns3_is_device(struct cdns3 *cdns)
        if (cdns->dr_mode == USB_DR_MODE_PERIPHERAL)
                return true;
        else if (cdns->dr_mode == USB_DR_MODE_OTG)
-               if (cdns3_get_id(cdns))
+               if (cdns3_get_id(cdns) == CDNS3_ID_PERIPHERAL)
                        return true;
 
        return false;

diff --git a/drivers/usb/cdns3/drd.h b/drivers/usb/cdns3/drd.h
index 35b6d459ee58c18daf2f97cbc1d2a7f282dc5bc7..3889fead9df196ff84bb753c1598e4997286a8a5 100644 (file)
--- a/drivers/usb/cdns3/drd.h
+++ b/drivers/usb/cdns3/drd.h
@@ -153,6 +153,9 @@ struct cdns3_otg_common_regs {
 /* Only for CDNS3_CONTROLLER_V0 version */
 #define OVERRIDE_IDPULLUP_V0           BIT(24)
 
+#define CDNS3_ID_PERIPHERAL            1
+#define CDNS3_ID_HOST                  0
+
 bool cdns3_is_host(struct cdns3 *cdns);
 bool cdns3_is_device(struct cdns3 *cdns);
 int cdns3_get_id(struct cdns3 *cdns);