]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
i3c: fix missing detach if failed to retrieve i3c dev
authorJisheng Zhang <Jisheng.Zhang@synaptics.com>
Fri, 25 Jan 2019 07:40:32 +0000 (07:40 +0000)
committerBoris Brezillon <bbrezillon@kernel.org>
Fri, 25 Jan 2019 07:48:01 +0000 (08:48 +0100)
If we failed to retrieve the i3c dev, we should detach the i3c dev
I.E i3c_master_detach_i3c_dev().

Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
drivers/i3c/master.c

index c39f89d2debaae9bd37bb3d5f4e252628a8435fd..2dc628d4f1aee1b5c07593f85e7d75a6bdb3d0be 100644 (file)
@@ -1828,7 +1828,7 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
 
        ret = i3c_master_retrieve_dev_info(newdev);
        if (ret)
-               goto err_free_dev;
+               goto err_detach_dev;
 
        olddev = i3c_master_search_i3c_dev_duplicate(newdev);
        if (olddev) {