]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
watchdog: hpwdt: Claim NMI from iLO
authorJerry Hoemann <jerry.hoemann@hpe.com>
Wed, 8 Aug 2018 19:13:24 +0000 (13:13 -0600)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Tue, 2 Oct 2018 11:32:21 +0000 (13:32 +0200)
The hwpdt driver is overloaded for handling both the iLO
watchdog and the explicit "Generate NMI to System" virutal
button.  Hence NMI handler needs to claim NMI resulting
from the virutal button.

Claim if iLO generated accommodating firmware that might
set wrong bit.

Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/hpwdt.c

index fae93643beaba7a8b314f4a1ef87051688705b70..bb4171447a1363beaef594df401b58157f1ba76d 100644 (file)
@@ -162,7 +162,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
        if (ilo5 && ulReason == NMI_UNKNOWN && !mynmi)
                return NMI_DONE;
 
-       if (ilo5 && !pretimeout)
+       if (ilo5 && !pretimeout && !mynmi)
                return NMI_DONE;
 
        hpwdt_stop();