]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
wlcore: sdio: check for valid platform device data before suspend
authorEyal Reizer <eyalreizer@gmail.com>
Mon, 28 May 2018 08:36:42 +0000 (11:36 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 1 Mar 2019 13:20:35 +0000 (14:20 +0100)
BugLink: http://bugs.launchpad.net/bugs/1815234
[ Upstream commit 6e91d48371e79862ea2c05867aaebe4afe55a865 ]

the wl pointer can be null In case only wlcore_sdio is probed while
no WiLink module is successfully probed, as in the case of mounting a
wl12xx module while using a device tree file configured with wl18xx
related settings.
In this case the system was crashing in wl1271_suspend() as platform
device data is not set.
Make sure wl the pointer is valid before using it.

Signed-off-by: Eyal Reizer <eyalr@ti.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/wireless/ti/wlcore/sdio.c

index f8a1fea64e2567c6b368e2fc93a667b1a9bbb0ae..219d1a86b92ecb3f48491ab8034ef62e74790d38 100644 (file)
@@ -406,6 +406,11 @@ static int wl1271_suspend(struct device *dev)
        mmc_pm_flag_t sdio_flags;
        int ret = 0;
 
+       if (!wl) {
+               dev_err(dev, "no wilink module was probed\n");
+               goto out;
+       }
+
        dev_dbg(dev, "wl1271 suspend. wow_enabled: %d\n",
                wl->wow_enabled);