]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
ASoC: Intel: cht_bsw_nau8824: fix kernel oops with platform_name override
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 4 Jun 2019 20:08:57 +0000 (15:08 -0500)
committerMark Brown <broonie@kernel.org>
Thu, 6 Jun 2019 16:24:08 +0000 (17:24 +0100)
The platform override code uses devm_ functions to allocate memory for
the new name but the card device is not initialized. Fix by moving the
init earlier.

Fixes: 4506db8043341 ("ASoC: Intel: cht_bsw_nau8824: platform name fixup support")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/cht_bsw_nau8824.c

index 02c2fa23933107a5c8a20cc1f2be96d2d2dcf419..20fae391c75a19e31bacc37f5a3c3818c2292be1 100644 (file)
@@ -257,6 +257,7 @@ static int snd_cht_mc_probe(struct platform_device *pdev)
        snd_soc_card_set_drvdata(&snd_soc_card_cht, drv);
 
        /* override plaform name, if required */
+       snd_soc_card_cht.dev = &pdev->dev;
        mach = (&pdev->dev)->platform_data;
        platform_name = mach->mach_params.platform;
 
@@ -266,7 +267,6 @@ static int snd_cht_mc_probe(struct platform_device *pdev)
                return ret_val;
 
        /* register the soc card */
-       snd_soc_card_cht.dev = &pdev->dev;
        ret_val = devm_snd_soc_register_card(&pdev->dev, &snd_soc_card_cht);
        if (ret_val) {
                dev_err(&pdev->dev,