]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
netfilter: conntrack: use power efficient workqueue
authorVincent Guittot <vincent.guittot@linaro.org>
Thu, 2 Nov 2017 15:16:07 +0000 (16:16 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 6 Nov 2017 23:59:10 +0000 (00:59 +0100)
conntrack uses the bounded system_long_wq workqueue for its works that
don't have to run on the cpu they have been queued.
Using bounded workqueue prevents the scheduler to make smart decision about
the best place to schedule the work.

This patch replaces system_long_wq with system_power_efficient_wq. the work
stays bounded to a cpu by default unless the CONFIG_WQ_POWER_EFFICIENT is
enable. In the latter case, the work can be scheduled on the best cpu from
a power or a performance point of view.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_core.c

index 0e516947c16f0f2c9b0d27812866b50294f701c8..5749fcaa2770ed1d13276b3eba764f239e1c8e04 100644 (file)
@@ -1083,7 +1083,7 @@ static void gc_worker(struct work_struct *work)
        next_run = gc_work->next_gc_run;
        gc_work->last_bucket = i;
        gc_work->early_drop = false;
-       queue_delayed_work(system_long_wq, &gc_work->dwork, next_run);
+       queue_delayed_work(system_power_efficient_wq, &gc_work->dwork, next_run);
 }
 
 static void conntrack_gc_work_init(struct conntrack_gc_work *gc_work)
@@ -2089,7 +2089,7 @@ int nf_conntrack_init_start(void)
                goto err_proto;
 
        conntrack_gc_work_init(&conntrack_gc_work);
-       queue_delayed_work(system_long_wq, &conntrack_gc_work.dwork, HZ);
+       queue_delayed_work(system_power_efficient_wq, &conntrack_gc_work.dwork, HZ);
 
        return 0;