]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
power: supply: ucs1002: Fix wrong return value checking
authorAxel Lin <axel.lin@ingics.com>
Thu, 9 May 2019 12:56:14 +0000 (20:56 +0800)
committerSebastian Reichel <sre@kernel.org>
Thu, 9 May 2019 19:44:15 +0000 (21:44 +0200)
Fix wrong return value checking for devm_regulator_register and
devm_regmap_init_i2c. This looks like a copy-n-paste mistake.

Fixes: 9a2688e42638 ("power: supply: Add driver for Microchip UCS1002")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/ucs1002_power.c

index d66b4eff9b7a0247d9b5444e8e7341533bebbd4c..1c89d030c0452e72d762a64a5c4f373d5224a593 100644 (file)
@@ -508,7 +508,7 @@ static int ucs1002_probe(struct i2c_client *client,
                return -ENOMEM;
 
        info->regmap = devm_regmap_init_i2c(client, &regmap_config);
-       ret = PTR_ERR_OR_ZERO(info->charger);
+       ret = PTR_ERR_OR_ZERO(info->regmap);
        if (ret) {
                dev_err(dev, "Regmap initialization failed: %d\n", ret);
                return ret;
@@ -592,7 +592,7 @@ static int ucs1002_probe(struct i2c_client *client,
 
        rdev = devm_regulator_register(dev, info->regulator_descriptor,
                                       &regulator_config);
-       ret = PTR_ERR_OR_ZERO(info->charger);
+       ret = PTR_ERR_OR_ZERO(rdev);
        if (ret) {
                dev_err(dev, "Failed to register VBUS regulator: %d\n", ret);
                return ret;