]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
octeon_mgmt: drop redundant mac address check
authorLuka Perkov <luka@openwrt.org>
Tue, 29 Oct 2013 23:09:12 +0000 (00:09 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Oct 2013 02:52:44 +0000 (22:52 -0400)
Checking if MAC address is valid using is_valid_ether_addr() is already done in
of_get_mac_address().

Signed-off-by: Luka Perkov <luka@openwrt.org>
Acked-by: David Daney <david.daney@cavium.com>
CC: David Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/octeon/octeon_mgmt.c

index 622aa75904c4ee07c1b666466925e08ce0df25d3..1b326cbcd34b1bb9334635ff832b2cfd560ea905 100644 (file)
@@ -1545,7 +1545,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
 
        mac = of_get_mac_address(pdev->dev.of_node);
 
-       if (mac && is_valid_ether_addr(mac))
+       if (mac)
                memcpy(netdev->dev_addr, mac, ETH_ALEN);
        else
                eth_hw_addr_random(netdev);