]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
leds: led-triggers: Fix checkpatch warnings
authorSachin Kamat <sachin.kamat@linaro.org>
Sun, 25 Nov 2012 07:30:44 +0000 (13:00 +0530)
committerBryan Wu <cooloney@gmail.com>
Tue, 27 Nov 2012 22:49:30 +0000 (14:49 -0800)
Fixes the following type of warnings:
WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ...
then pr_warn(...  to printk(KERN_WARNING ...
WARNING: quoted string split across lines

While at it also fix a coding style issue w.r.t braces.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
drivers/leds/led-triggers.c

index a4fa4bf02d538cdd30711b7ba93558d38cd690bc..3c972b2f989335e4df54aa8436cbd99a7f19ba09 100644 (file)
@@ -313,13 +313,13 @@ void led_trigger_register_simple(const char *name, struct led_trigger **tp)
                if (err < 0) {
                        kfree(trig);
                        trig = NULL;
-                       printk(KERN_WARNING "LED trigger %s failed to register"
-                               " (%d)\n", name, err);
+                       pr_warn("LED trigger %s failed to register (%d)\n",
+                               name, err);
                }
-       } else
-               printk(KERN_WARNING "LED trigger %s failed to register"
-                       " (no memory)\n", name);
-
+       } else {
+               pr_warn("LED trigger %s failed to register (no memory)\n",
+                       name);
+       }
        *tp = trig;
 }
 EXPORT_SYMBOL_GPL(led_trigger_register_simple);