]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
drm/hisilicon/hibmc: Checking for NULL instead of IS_ERR()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 24 Nov 2016 11:35:45 +0000 (14:35 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 25 Nov 2016 06:58:49 +0000 (07:58 +0100)
The drm_dev_alloc() function returns error pointers.  It never returns
NULLs.

Fixes: 5e0df3a08f3d ("drm/hisilicon/hibmc: Add hisilicon hibmc drm master driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20161124113545.GP17225@mwanda
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c

index 73ba8b05f1da3c673709ec5655e925fd1fa754e1..d94e3495c9b208359a2c2717a39fe0847528f3a3 100644 (file)
@@ -377,9 +377,9 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
        int ret;
 
        dev = drm_dev_alloc(&hibmc_driver, &pdev->dev);
-       if (!dev) {
+       if (IS_ERR(dev)) {
                DRM_ERROR("failed to allocate drm_device\n");
-               return -ENOMEM;
+               return PTR_ERR(dev);
        }
 
        dev->pdev = pdev;