]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
Staging: greybus: style fix, permissions as octal
authorDerek Robson <robsonde@gmail.com>
Thu, 12 Jan 2017 04:59:40 +0000 (17:59 +1300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Jan 2017 17:08:56 +0000 (18:08 +0100)
Changed permissions to be in octal style.
Found by checkpatch.

Signed-off-by: Derek Robson <robsonde@gmail.com>
Acked-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/camera.c

index 0ee291ca2c721aa7e306e4275b9a97eefbd4f0c1..a64517eabff4cd146cb89d139aa3988e3a7409ef 100644 (file)
@@ -1067,22 +1067,22 @@ struct gb_camera_debugfs_entry {
 static const struct gb_camera_debugfs_entry gb_camera_debugfs_entries[] = {
        {
                .name = "capabilities",
-               .mask = S_IFREG | S_IRUGO,
+               .mask = S_IFREG | 0444,
                .buffer = GB_CAMERA_DEBUGFS_BUFFER_CAPABILITIES,
                .execute = gb_camera_debugfs_capabilities,
        }, {
                .name = "configure_streams",
-               .mask = S_IFREG | S_IRUGO | S_IWUGO,
+               .mask = S_IFREG | 0666,
                .buffer = GB_CAMERA_DEBUGFS_BUFFER_STREAMS,
                .execute = gb_camera_debugfs_configure_streams,
        }, {
                .name = "capture",
-               .mask = S_IFREG | S_IRUGO | S_IWUGO,
+               .mask = S_IFREG | 0666,
                .buffer = GB_CAMERA_DEBUGFS_BUFFER_CAPTURE,
                .execute = gb_camera_debugfs_capture,
        }, {
                .name = "flush",
-               .mask = S_IFREG | S_IRUGO | S_IWUGO,
+               .mask = S_IFREG | 0666,
                .buffer = GB_CAMERA_DEBUGFS_BUFFER_FLUSH,
                .execute = gb_camera_debugfs_flush,
        },
@@ -1097,7 +1097,7 @@ static ssize_t gb_camera_debugfs_read(struct file *file, char __user *buf,
        ssize_t ret;
 
        /* For read-only entries the operation is triggered by a read. */
-       if (!(op->mask & S_IWUGO)) {
+       if (!(op->mask & 0222)) {
                ret = op->execute(gcam, NULL, 0);
                if (ret < 0)
                        return ret;