]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
drm/amd/display: Cast int to float before division
authorSung Lee <sung.lee@amd.com>
Mon, 30 Mar 2020 21:16:23 +0000 (17:16 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 22 Apr 2020 22:11:47 +0000 (18:11 -0400)
[Why]:
Some inputs to dml_ceil have it dividied by int which causes a
truncation. This loss of precision means the ceil function becomes
redundant and does not round up.

[How]:
Cast parameter to float before division.

Signed-off-by: Sung Lee <sung.lee@amd.com>
Reviewed-by: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c

index e6617c958bb8bfb26ef690facecec0432ae43fb2..5bc80b6084da38f9543e0828dc45b8d42fcb856f 100644 (file)
@@ -5944,7 +5944,7 @@ static void CalculateMetaAndPTETimes(
                                                * PixelPTEReqHeightY[k];
                        }
                        dpte_groups_per_row_luma_ub = dml_ceil(
-                                       dpte_row_width_luma_ub[k] / dpte_group_width_luma,
+                                       (float) dpte_row_width_luma_ub[k] / dpte_group_width_luma,
                                        1);
                        time_per_pte_group_nom_luma[k] = DST_Y_PER_PTE_ROW_NOM_L[k] * HTotal[k]
                                        / PixelClock[k] / dpte_groups_per_row_luma_ub;
@@ -5968,7 +5968,7 @@ static void CalculateMetaAndPTETimes(
                                                        * PixelPTEReqHeightC[k];
                                }
                                dpte_groups_per_row_chroma_ub = dml_ceil(
-                                               dpte_row_width_chroma_ub[k]
+                                               (float) dpte_row_width_chroma_ub[k]
                                                                / dpte_group_width_chroma,
                                                1);
                                time_per_pte_group_nom_chroma[k] = DST_Y_PER_PTE_ROW_NOM_C[k]