]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
hwmon: (jz4740) fix signedness bug
authorAxel Lin <axel.lin@gmail.com>
Thu, 8 Dec 2011 13:04:12 +0000 (08:04 -0500)
committerGuenter Roeck <guenter.roeck@ericsson.com>
Mon, 12 Dec 2011 16:31:21 +0000 (08:31 -0800)
wait_for_completion_interruptible_timeout() may return negative value.
In this case, checking if (t > 0)  will return true if t is unsigned.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: stable@kernel.org (3.0+)
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
drivers/hwmon/jz4740-hwmon.c

index 7a48b1eb423334780116f1cb6e16edcec8f19a49..3d7e590d57b71106ed1e2c6f4311a5cbae163501 100644 (file)
@@ -59,7 +59,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev,
 {
        struct jz4740_hwmon *hwmon = dev_get_drvdata(dev);
        struct completion *completion = &hwmon->read_completion;
-       unsigned long t;
+       long t;
        unsigned long val;
        int ret;