]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: hns3: optimize local variable initialization
authorGuangbin Huang <huangguangbin2@huawei.com>
Thu, 31 Oct 2019 11:23:21 +0000 (19:23 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 31 Oct 2019 19:03:23 +0000 (12:03 -0700)
The variable tx_ring is unnecessary to be initialized as it will be set
before used, and the variable rst_cnt is better to be initialized when
declaration for simplification.

Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index 23bdfe8583da62a0f9aab3c166fde64936a69b61..82ed9c4485fb016c39598a31f0ec068b1b18fb91 100644 (file)
@@ -1771,7 +1771,7 @@ static bool hns3_get_tx_timeo_queue_info(struct net_device *ndev)
 {
        struct hns3_nic_priv *priv = netdev_priv(ndev);
        struct hnae3_handle *h = hns3_get_handle(ndev);
-       struct hns3_enet_ring *tx_ring = NULL;
+       struct hns3_enet_ring *tx_ring;
        struct napi_struct *napi;
        int timeout_queue = 0;
        int hw_head, hw_tail;
index 69ab86a4b38dcbc4ef03d5f6af57a9dd20731565..300252785ad85a7a48261b3871053557a78ca949 100644 (file)
@@ -8992,10 +8992,9 @@ static int hclge_init_nic_client_instance(struct hnae3_ae_dev *ae_dev,
 {
        struct hnae3_client *client = vport->nic.client;
        struct hclge_dev *hdev = ae_dev->priv;
-       int rst_cnt;
+       int rst_cnt = hdev->rst_stats.reset_cnt;
        int ret;
 
-       rst_cnt = hdev->rst_stats.reset_cnt;
        ret = client->ops->init_instance(&vport->nic);
        if (ret)
                return ret;