RDMA/bnxt_re: Fix a couple off by one bugs

BugLink: https://bugs.launchpad.net/bugs/1836287
[ Upstream commit 474e5a86067e5f12c97d1db8b170c7f45b53097a ]

The sgid_tbl->tbl[] array is allocated in bnxt_qplib_alloc_sgid_tbl().
It has sgid_tbl->max elements.  So the > should be >= to prevent
accessing one element beyond the end of the array.

Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
index 64aa68d62f96ce0c3cb807009bb0274f891cd00b..ff4fdd4c7150390f88d8554e569d6b3b40829cb3 100644 (file)
--- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
@@ -156,7 +156,7 @@ int bnxt_qplib_get_sgid(struct bnxt_qplib_res *res,
                        struct bnxt_qplib_sgid_tbl *sgid_tbl, int index,
                        struct bnxt_qplib_gid *gid)
 {
-       if (index > sgid_tbl->max) {
+       if (index >= sgid_tbl->max) {
                dev_err(&res->pdev->dev,
                        "QPLIB: Index %d exceeded SGID table max (%d)",
                        index, sgid_tbl->max);
@@ -361,7 +361,7 @@ int bnxt_qplib_get_pkey(struct bnxt_qplib_res *res,
                *pkey = 0xFFFF;
                return 0;
        }
-       if (index > pkey_tbl->max) {
+       if (index >= pkey_tbl->max) {
                dev_err(&res->pdev->dev,
                        "QPLIB: Index %d exceeded PKEY table max (%d)",
                        index, pkey_tbl->max);