]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
b44: Fix wedge when using netconsole.
authorDavid S. Miller <davem@davemloft.net>
Mon, 30 Nov 2009 08:13:28 +0000 (00:13 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Nov 2009 08:13:28 +0000 (00:13 -0800)
Fixes kernel bugzilla #14691

Due to the way netpoll works, it is perfectly legal to see
NAPI already scheduled when new device events are pending
in b44_interrupt().

So logging a message about it is wrong and in fact harmful.

Based upon a patch by Andreas Mohr.

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/b44.c

index e046943ef29dc6c9243bb84ad0c5ab5fcdde19bf..2a9132343b66135fb2487c30a20ba6ce0db786ec 100644 (file)
@@ -912,9 +912,6 @@ static irqreturn_t b44_interrupt(int irq, void *dev_id)
                        bp->istat = istat;
                        __b44_disable_ints(bp);
                        __napi_schedule(&bp->napi);
-               } else {
-                       printk(KERN_ERR PFX "%s: Error, poll already scheduled\n",
-                              dev->name);
                }
 
 irq_ack: