]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ASoC: amd: Fix reference to PCM buffer address
authorMeng Tang <tangmeng@uniontech.com>
Wed, 16 Mar 2022 09:13:03 +0000 (17:13 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:38:36 +0000 (14:38 +0200)
BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit 54e1bf9f6177a3ffbd920474f4481a25361163aa ]

PCM buffers might be allocated dynamically when the buffer
preallocation failed or a larger buffer is requested, and it's not
guaranteed that substream->dma_buffer points to the actually used
buffer.  The driver needs to refer to substream->runtime->dma_addr
instead for the buffer address.

Fixes: cab396d8b22c1 ("ASoC: amd: add ACP5x pcm dma driver ops")
Signed-off-by: Meng Tang <tangmeng@uniontech.com>
Link: https://lore.kernel.org/r/20220316091303.9745-1-tangmeng@uniontech.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit c2e5f5d23718dbc4d9ce21c69d78d32f2eaa1ec8)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
sound/soc/amd/vangogh/acp5x-pcm-dma.c

index f10de38976cb54cd1067115ba0084e89f355f2ed..6abcc2133a2c6bf80d03cd31661241c3fb36dd34 100644 (file)
@@ -281,7 +281,7 @@ static int acp5x_dma_hw_params(struct snd_soc_component *component,
                return -EINVAL;
        }
        size = params_buffer_bytes(params);
-       rtd->dma_addr = substream->dma_buffer.addr;
+       rtd->dma_addr = substream->runtime->dma_addr;
        rtd->num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
        config_acp5x_dma(rtd, substream->stream);
        return 0;