]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
ARM: OMAP2+: hwmod: Add of_node_put() before break
authorWan Jiabing <wanjiabing@vivo.com>
Thu, 14 Oct 2021 08:57:19 +0000 (04:57 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 14 Apr 2022 09:32:26 +0000 (11:32 +0200)
BugLink: https://bugs.launchpad.net/bugs/1967582
[ Upstream commit 80c469a0a03763f814715f3d12b6f3964c7423e8 ]

Fix following coccicheck warning:
./arch/arm/mach-omap2/omap_hwmod.c:753:1-23: WARNING: Function
for_each_matching_node should have of_node_put() before break

Early exits from for_each_matching_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
arch/arm/mach-omap2/omap_hwmod.c

index 6289b288d60a6a2229932dfbb870bc3eaafbb85c..202b740adee0e85cad01a9acc281f6938d7f3d13 100644 (file)
@@ -782,8 +782,10 @@ static int __init _init_clkctrl_providers(void)
 
        for_each_matching_node(np, ti_clkctrl_match_table) {
                ret = _setup_clkctrl_provider(np);
-               if (ret)
+               if (ret) {
+                       of_node_put(np);
                        break;
+               }
        }
 
        return ret;