]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
ARM: mvebu: use the correct phy connection mode on Armada 385 DB
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thu, 6 Mar 2014 14:41:55 +0000 (15:41 +0100)
committerJason Cooper <jason@lakedaemon.net>
Thu, 6 Mar 2014 20:08:05 +0000 (20:08 +0000)
On Armada 385 DB, while the "rgmii" PHY connection mode works fine
with the generic PHY driver, it fails to work when the Marvell PHY
driver is enabled in the kernel configuration, due to a finer handling
of the PHY configuration. This is due to the fact that the phy
connection mode should instead be "rgmii-id", i.e with the TX/RX delay
mechanisms enabled.

This fixes the network operation on Armada 385 DB with
CONFIG_MARVELL_PHY=y. Without this patch and this option enabled, one
would only get messages such as:

  mvneta f1070000.ethernet eth1: bad rx status 0cc10000 (crc error), size=70

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
arch/arm/boot/dts/armada-385-db.dts

index 01b6cc76ddc8677c3877d6b8e2755da0bcd6ddfd..9a136428ec29272cd72dbb9e9198aa5d723dd170 100644 (file)
                        ethernet@30000 {
                                status = "okay";
                                phy = <&phy1>;
-                               phy-mode = "rgmii";
+                               phy-mode = "rgmii-id";
                        };
 
                        ethernet@70000 {
                                status = "okay";
                                phy = <&phy0>;
-                               phy-mode = "rgmii";
+                               phy-mode = "rgmii-id";
                        };
 
                        mdio {