usb: dwc3: gadget: fixing dequeue of TRBs

A TRB which is dequeued seems to have its HWO bits set to 1. Therefore
we ignore it if we dequeue it after the command is completed.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index cebaef720cd48beb4b5fd07ffbc5880e263c4edf..56f0e46c00adf4f82826f9f31e685fa9ee6aa6cd 100644 (file)
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1309,11 +1309,17 @@ static int dwc3_cleanup_done_reqs(struct dwc3 *dwc, struct dwc3_ep *dep,
 
                dwc3_trb_to_nat(req->trb, &trb);
 
-               if (trb.hwo) {
+               if (trb.hwo && status != -ESHUTDOWN)
+                       /*
+                        * We continue despite the error. There is not much we
+                        * can do. If we don't clean in up we loop for ever. If
+                        * we skip the TRB than it gets overwritten reused after
+                        * a while since we use them in a ring buffer. a BUG()
+                        * would help. Lets hope that if this occures, someone
+                        * fixes the root cause instead of looking away :)
+                        */
                        dev_err(dwc->dev, "%s's TRB (%p) still owned by HW\n",
                                        dep->name, req->trb);
-                       continue;
-               }
                count = trb.length;
 
                if (dep->direction) {