]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ASoC: SOF: Intel: hda: reduce verbosity on SoundWire detection
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 9 Apr 2020 18:44:14 +0000 (13:44 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 14 Apr 2020 12:39:49 +0000 (13:39 +0100)
No need to report an error when SoundWire is not detected (not present
in hardware or not exposed in ACPI). Move to dev_dbg to state that
SoundWire is skipped.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200409184416.15591-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda.c

index 211e91e79eae02f8a52283d7c56ed7521c7c86ce..6cbe2edc868c365ab48687ea7dd6e43bc1dece77 100644 (file)
@@ -135,10 +135,8 @@ static int hda_sdw_acpi_scan(struct snd_sof_dev *sdev)
        hdev = sdev->pdata->hw_pdata;
 
        ret = sdw_intel_acpi_scan(handle, &hdev->info);
-       if (ret < 0) {
-               dev_err(sdev->dev, "%s failed\n", __func__);
+       if (ret < 0)
                return -EINVAL;
-       }
 
        return 0;
 }
@@ -604,7 +602,7 @@ static int hda_init_caps(struct snd_sof_dev *sdev)
        /* scan SoundWire capabilities exposed by DSDT */
        ret = hda_sdw_acpi_scan(sdev);
        if (ret < 0) {
-               dev_dbg(sdev->dev, "skipping SoundWire, ACPI scan error\n");
+               dev_dbg(sdev->dev, "skipping SoundWire, not detected with ACPI scan\n");
                goto skip_soundwire;
        }