]> git.proxmox.com Git - mirror_qemu.git/commitdiff
blockdev-backup: Use bdrv_lookup_bs on target
authorFam Zheng <famz@redhat.com>
Mon, 23 May 2016 02:19:35 +0000 (10:19 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 7 Jun 2016 13:40:50 +0000 (14:40 +0100)
This allows backing up to a BDS that has not been attached to any BB.

Signed-off-by: Fam Zheng <famz@redhat.com>
Message-id: 1463969978-24970-2-git-send-email-famz@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
blockdev.c

index 717785eb8deac43401ea4ec5842b85daf6038465..ea7f3974e2dbdb5459b59e84d61a0621fd418aa5 100644 (file)
@@ -3335,7 +3335,7 @@ void do_blockdev_backup(const char *device, const char *target,
                          BlockdevOnError on_target_error,
                          BlockJobTxn *txn, Error **errp)
 {
-    BlockBackend *blk, *target_blk;
+    BlockBackend *blk;
     BlockDriverState *bs;
     BlockDriverState *target_bs;
     Error *local_err = NULL;
@@ -3366,17 +3366,10 @@ void do_blockdev_backup(const char *device, const char *target,
     }
     bs = blk_bs(blk);
 
-    target_blk = blk_by_name(target);
-    if (!target_blk) {
-        error_setg(errp, "Device '%s' not found", target);
-        goto out;
-    }
-
-    if (!blk_is_available(target_blk)) {
-        error_setg(errp, "Device '%s' has no medium", target);
+    target_bs = bdrv_lookup_bs(target, target, errp);
+    if (!target_bs) {
         goto out;
     }
-    target_bs = blk_bs(target_blk);
 
     bdrv_set_aio_context(target_bs, aio_context);
     backup_start(bs, target_bs, speed, sync, NULL, on_source_error,