]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
Staging: iio: adis16209: Adjust a switch statement
authorShreeya Patel <shreeya.patel23498@gmail.com>
Sun, 4 Mar 2018 12:43:12 +0000 (18:13 +0530)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 7 Mar 2018 21:06:52 +0000 (21:06 +0000)
Adjust a switch block to explicitly match channels and
return -EINVAL as default case which makes the code
semantically more clear.

Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/accel/adis16209.c

index 68a2f2f80f88a8678bf74670443090d98ec514d3..8ffde7ea94c4375e62f34b74d5d29e945c53b2fd 100644 (file)
@@ -155,10 +155,16 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
                switch (chan->type) {
                case IIO_VOLTAGE:
                        *val = 0;
-                       if (chan->channel == 0)
+                       switch (chan->channel) {
+                       case 0:
                                *val2 = 305180; /* 0.30518 mV */
-                       else
+                               break;
+                       case 1:
                                *val2 = 610500; /* 0.6105 mV */
+                               break;
+                       default:
+                               return -EINVAL;
+                       }
                        return IIO_VAL_INT_PLUS_MICRO;
                case IIO_TEMP:
                        *val = -470;