]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
gpio: raspberrypi-exp: Release firmware handle on unbind
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Mon, 18 Jan 2021 12:32:37 +0000 (13:32 +0100)
committerNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Mon, 22 Mar 2021 16:59:51 +0000 (17:59 +0100)
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-raspberrypi-exp.c

index bb100e0124e6306698a71c40e721c3fce51a6467..64a552ecc2addde9f9df9c9e1e23295d2d105f80 100644 (file)
@@ -208,7 +208,7 @@ static int rpi_exp_gpio_probe(struct platform_device *pdev)
                return -ENOENT;
        }
 
-       fw = rpi_firmware_get(fw_node);
+       fw = devm_rpi_firmware_get(&pdev->dev, fw_node);
        of_node_put(fw_node);
        if (!fw)
                return -EPROBE_DEFER;